SimpleHeater: use IDLE state to properly show up in HomeKit, add offset for currentTemperature, fix targetTemperatureDivisor #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omeKit. state only changes above or below desiredTemperature, as all divices I know do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleHeater:
a) doesn't properly reflect the state of the Heater, because it only uses HEATING and INACTIVE.
If a Heater is above its target temerature, the heater ist still active, but in IDLE mode.
b) Temparature measurement of a heater may be off by some amount. Adding an offset will fix this
c) In SimpleHeater there's no need for targetTemperatureDivisor. Instead _getDividedState() is the way to do.
This fixes #467. Further _getDividedState() is used an essential for the temperature offset.
This PR adds these three issues.