Decode long instead of parseLong #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one case reading config files use decode instead of parseLong. decode accepts `0x` and decimal, only a single radix for parseLong. Signed-off-by: Danno Ferrin <[email protected]>
jflo
approved these changes
Feb 24, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -163,7 +163,7 @@ | |||
| .computeBaseFee( | |||
| number, | |||
| Wei.fromHexString(parentBaseFee), | |||
| Long.parseLong(parentGasUsed), | |||
| Long.decode(parentGasUsed), | |||
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
Signed-off-by: Danno Ferrin <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
In one case reading config files used parseLong instead of decode. decode accepts `0x` and decimal, only a single radix for parseLong. Signed-off-by: Danno Ferrin <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
In one case reading config files used parseLong instead of decode. decode accepts `0x` and decimal, only a single radix for parseLong. Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In one case reading config files use decode instead of parseLong. decode accepts
0xand decimal, only a single radix for parseLong.Fixed Issue(s)
fixes #5134
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog