(refactor) Centralise dependencies definitions into workspace version catalog #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naian <[email protected]>
The resulting benefits should be * easy upgrade of deps in future * may help reduce binary size (as we carry fewer versions of each dep) Signed-off-by: Naian <[email protected]>
nain-F49FF806
force-pushed
the
refactor/version-catalog
branch
from
f825797 to
0ab960b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall facing a lot of dependency conflicts when adding or updating any dependency.
This was in part because all our packages define their own dependencies individually,
and since there's cross dependencies among our crates, there would often be version conflicts.
For example when adding a new dependency or updating an existing one.
This PR centralises as many dependencies as possible into the workspace definition.
So there's one central place to define versions.
One can always manually use a different version in a package if desired.
The resulting benefits should be: