Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

lukewli-anonyome · 2024-01-10T18:17:59Z

This PR introduces a fix for the DIDDoc resolution error outlined in issue #1090 and the shorthand verkey error outlined in issue #1091.

Closes #1090
Closes #1091

codecov-commenter · 2024-01-10T18:23:04Z

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (7614685) 0.05% compared to head (11828fa) 0.05%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
aries/aries_vcx/src/common/signing.rs	0.00%	23 Missing ⚠️
...ries/misc/legacy/diddoc_legacy/src/aries/diddoc.rs	0.00%	4 Missing ⚠️
aries/aries_vcx/src/common/credentials/encoding.rs	0.00%	1 Missing ⚠️
...ies/aries_vcx/src/handlers/out_of_band/receiver.rs	0.00%	1 Missing ⚠️
aries/aries_vcx/src/handlers/util.rs	0.00%	1 Missing ⚠️
aries/aries_vcx/src/protocols/did_exchange/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main   #1105      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     478       +7     
  Lines      24093   24334     +241     
  Branches    4332    4370      +38     
========================================
  Hits          13      13              
- Misses     24079   24320     +241     
  Partials       1       1

Flag	Coverage Δ
unittests-aries-vcx	`0.05% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmulhearn-anonyome · 2024-01-10T22:10:51Z

weird that this clippy error is just showing up now :( maybe try fixing it (removing the dep)

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs

Patrik-Stas · 2024-03-15T04:42:39Z

@lukewli-anonyome @gmulhearn-anonyome I am sorry folks for the conflicts that have arose after finally merging #1097

However, when you have bandwidth feel free to resume this effort

Signed-off-by: lli <[email protected]>

did_core/did_methods/did_resolver_sov/tests/resolution.rs

Signed-off-by: lli <[email protected]>

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs

gmulhearn

nice! thanks Luke

…t a service/endpoint and expands shorthand verkey notation for publicKeyBase58 (hyperledger#1105) * lli - Added Solution/Tests Signed-off-by: lli <[email protected]> * lli - merge issue 1090 Signed-off-by: lli <[email protected]> * lli - Add Resolution Test back Signed-off-by: lli <[email protected]> * lli - Clippy fixes Signed-off-by: lli <[email protected]> * lli - Clippy fixes Signed-off-by: lli <[email protected]> * lli - Clippy fixes Signed-off-by: lli <[email protected]> * lli - Clippy fixes Signed-off-by: lli <[email protected]> * lli - Clippy fixes Signed-off-by: lli <[email protected]> * lli - Fix Expanding Verkey Fn Signed-off-by: lli <[email protected]> * lli - Fix unwrapping err Signed-off-by: lli <[email protected]> * lli - Remove unwraps Signed-off-by: lli <[email protected]> * lli - use ddo_id to retrieve nym Signed-off-by: lli <[email protected]> * Merge Conflicts Signed-off-by: lli <[email protected]> * Merge Conflicts Signed-off-by: lli <[email protected]> * Fixing Test Signed-off-by: lli <[email protected]> * formatting Signed-off-by: lli <[email protected]> * Fix tests Signed-off-by: lli <[email protected]> * Clippy Signed-off-by: lli <[email protected]> * Fix Endpoint Test Signed-off-by: lli <[email protected]> * Remove print Signed-off-by: lli <[email protected]> * Log response error Signed-off-by: lli <[email protected]> --------- Signed-off-by: lli <[email protected]>

gmulhearn-anonyome reviewed Jan 10, 2024

View reviewed changes

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs Outdated Show resolved Hide resolved

lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch 2 times, most recently from 9b411bd to 04e8133 Compare January 11, 2024 01:03

gmulhearn-anonyome reviewed Jan 12, 2024

View reviewed changes

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs Outdated Show resolved Hide resolved

gmulhearn-anonyome reviewed Jan 12, 2024

View reviewed changes

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs Outdated Show resolved Hide resolved

lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch 2 times, most recently from f66b78c to 7e98f27 Compare July 24, 2024 00:08

lli - Added Solution/Tests

8855c42

Signed-off-by: lli <[email protected]>

lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch from 2dd628c to 8236c92 Compare July 24, 2024 00:24

lukewli-anonyome added 14 commits July 23, 2024 18:04

lli - merge issue 1090

864c34d

Signed-off-by: lli <[email protected]>

lli - Add Resolution Test back

095a7fc

Signed-off-by: lli <[email protected]>

lli - Clippy fixes

fc4ea27

Signed-off-by: lli <[email protected]>

lli - Clippy fixes

76c0e63

Signed-off-by: lli <[email protected]>

lli - Clippy fixes

cf7996a

Signed-off-by: lli <[email protected]>

lli - Clippy fixes

861476e

Signed-off-by: lli <[email protected]>

lli - Clippy fixes

f65585f

Signed-off-by: lli <[email protected]>

lli - Fix Expanding Verkey Fn

10fc95b

Signed-off-by: lli <[email protected]>

lli - Fix unwrapping err

470c605

Signed-off-by: lli <[email protected]>

lli - Remove unwraps

3446459

Signed-off-by: lli <[email protected]>

lli - use ddo_id to retrieve nym

8b21680

Signed-off-by: lli <[email protected]>

Merge Conflicts

fcb3bfd

Signed-off-by: lli <[email protected]>

Merge Conflicts

1c4e84f

Signed-off-by: lli <[email protected]>

Fixing Test

623ceda

Signed-off-by: lli <[email protected]>

lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch from 8236c92 to 623ceda Compare July 24, 2024 01:04

lukewli-anonyome added 3 commits July 23, 2024 18:06

formatting

a811768

Signed-off-by: lli <[email protected]>

Fix tests

5e84737

Signed-off-by: lli <[email protected]>

Clippy

65b4f1f

Signed-off-by: lli <[email protected]>

gmulhearn reviewed Aug 6, 2024

View reviewed changes

did_core/did_methods/did_resolver_sov/tests/resolution.rs Outdated Show resolved Hide resolved

lukewli-anonyome added 3 commits August 6, 2024 15:22

Fix Endpoint Test

e82e629

Signed-off-by: lli <[email protected]>

Remove print

9805d79

Signed-off-by: lli <[email protected]>

Log response error

1b45d6d

Signed-off-by: lli <[email protected]>

gmulhearn reviewed Aug 7, 2024

View reviewed changes

did_core/did_methods/did_resolver_sov/src/resolution/utils.rs Show resolved Hide resolved

gmulhearn approved these changes Aug 7, 2024

View reviewed changes

gmulhearn merged commit b664ce7 into hyperledger:main Aug 7, 2024
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

lukewli-anonyome commented Jan 10, 2024

codecov-commenter commented Jan 10, 2024 •

edited

Loading

gmulhearn-anonyome commented Jan 10, 2024

Patrik-Stas commented Mar 15, 2024

gmulhearn left a comment

Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

Conversation

lukewli-anonyome commented Jan 10, 2024

codecov-commenter commented Jan 10, 2024 • edited Loading

Codecov Report

gmulhearn-anonyome commented Jan 10, 2024

Patrik-Stas commented Mar 15, 2024

gmulhearn left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 10, 2024 •

edited

Loading