Rust 1.75.0 #1673
Merged
Rust 1.75.0 #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
salaheldinsoliman
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
Signed-off-by: salaheldinsoliman <[email protected]>
seanyoung
reviewed
Nov 12, 2024
.github/workflows/release.yml
Outdated
| @@ -15,7 +15,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| submodules: recursive | |||
| - uses: dtolnay/rust-toolchain@1.74.0 | |||
| - uses: dtolnay/rust-toolchain@1.82.0 | |||
There was a problem hiding this comment.
1.75 should suffice here and everywhere below (keep the 1.82.0 fixes though).
Problem is that you are forcing anyone who uses the solang or solang-parser crate to update to 1.82.0, when it should work with older versions.
There was a problem hiding this comment.
Solang depends on a crate which requires 1.75.0: https://github.com/hyperledger-solang/solang/actions/runs/11792189166/job/32845426354?pr=1664#step:8:457
Should I upgrade to 1.75.0 instead?
There was a problem hiding this comment.
so it should be the lowest version that works
Signed-off-by: salaheldinsoliman <[email protected]>
seanyoung
approved these changes
Nov 12, 2024
|
Looks good, let's merge :) |
salaheldinsoliman
merged commit ead7929
into
hyperledger-solang:main
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Rust 1.75.0