Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format source code #1541

Merged
merged 33 commits into from
Oct 2, 2023
Merged

Format source code #1541

merged 33 commits into from
Oct 2, 2023

Conversation

chioni16
Copy link
Contributor

@chioni16 chioni16 commented Sep 17, 2023

We are importing forge-fmt for two reasons:

  • This ensures that forge-fmt uses the latest solang-parser crate, and we only have one version of solang-parser in solang binary
  • This makes it possible to publish the solang crate to crates.io, since forge-fmt is not on crates.io and no git depdendencies are allowed
  • We requested feedback from Foundry on their discord server but received no feedback

This feature is enabled with the help of forge-fmt.

Cc: @gakonst @DaniPopes

Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
@mattsse
Copy link
Contributor

mattsse commented Sep 20, 2023

hey @chioni16 sorry for being unresponsive

I think we can make this work, so that forge-fmt is available as crate

@mattsse
Copy link
Contributor

mattsse commented Sep 21, 2023

@chioni16 @seanyoung

published https://crates.io/crates/forge-fmt

lmk if anything is missing

Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
Signed-off-by: Govardhan G D <[email protected]>
@chioni16 chioni16 marked this pull request as ready for review September 29, 2023 14:51
@chioni16 chioni16 marked this pull request as draft October 1, 2023 09:30
@chioni16 chioni16 marked this pull request as ready for review October 1, 2023 10:32
seanyoung pushed a commit that referenced this pull request Oct 2, 2023
#1541 uses crate forge-fmt
which depends on rust 1.72

Signed-off-by: Govardhan G D <[email protected]>
@seanyoung
Copy link
Contributor

Thank you @chioni16 and @mattsse!

@seanyoung seanyoung merged commit 2fc1640 into hyperledger-solang:main Oct 2, 2023
16 checks passed
stainless-app bot pushed a commit to 2lambda123/hyperledger-solang that referenced this pull request Feb 4, 2024
hyperledger-solang/solang#1541 uses crate forge-fmt
which depends on rust 1.72

Signed-off-by: Govardhan G D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants