Verify account space specified in annotation #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
enough-space
branch
3 times, most recently
from
b439ad4 to
9ba34f4
Compare
seanyoung
reviewed
Sep 16, 2023
LucasSte
force-pushed
the
enough-space
branch
from
9ba34f4 to
7c26502
Compare
seanyoung
requested changes
Sep 19, 2023
LucasSte
force-pushed
the
enough-space
branch
from
7c26502 to
33a6953
Compare
LucasSte
force-pushed
the
enough-space
branch
from
33a6953 to
e1324bc
Compare
seanyoung
reviewed
Sep 21, 2023
LucasSte
force-pushed
the
enough-space
branch
from
e1324bc to
ed1bcfd
Compare
seanyoung
reviewed
Sep 24, 2023
LucasSte
force-pushed
the
enough-space
branch
from
ed1bcfd to
618eee3
Compare
seanyoung
approved these changes
Sep 26, 2023
Signed-off-by: Lucas Steuernagel <[email protected]>
LucasSte
force-pushed
the
enough-space
branch
from
618eee3 to
8e2811a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Solana, we can specify the space necessary for a contract's data account in the constructor with an annotation. We do not verify, however, if the declared space is enough to hold all the contract variables. As a consequence, we could call the constructor without any issue using a very small space value and hit other runtime errors later.
PS: I found it unpleasant to keep iterating over the constructor annotations to find the one we were looking for, so I replaced the vector by a struct to hold the permitted annotations.