refactor(schema_derive): use a smarter algorithm for auto-generated trait bounds #5132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of the solution for #5130.
Solution
This PR changes the way
iroha_schema_derive
generates trait bounds to the same algorithm that is used byparity-scale-codec
.In general, it adds a bound on
IntoSchema
for types of all the fields that use the generic parameters, with some special handling for#[codec(skip)]
,#[codec(compact)]
and recursive types.See docs for
trait_bounds::add
for more details.All of the
#[schema(bounds = ...)]
attributes are removed now, as there's no need for them anymore.Review notes
Checklist
CONTRIBUTING.md
.