Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents/sealevel): handle non configured igp account payments #5075

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

aroralanuk
Copy link
Contributor

Description

Drive-by changes

Related issues

Backward compatibility

Yes

Testing

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 3a8c10a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7dfcc60) to head (3a8c10a).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5075   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought about it, I'm down to do this for now but let's add a comment clearly flagging why we did this / what the impact is / indicating we may want to change in the future if we want to index multiple IGPs at a time

tracing::debug!(sealevel_payment=?sealevel_payment, igp_account_filter=?igp_account_filter, "Found interchain gas payment for a different IGP account, skipping");
tracing::debug!(sealevel_payment=?sealevel_payment, igp_account_filter=?igp_account_filter, "Found interchain gas payment for a different IGP account, neutralizing payment");

let non_matching_payment = InterchainGasPayment {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a little hard to read, could we change the logic around here starting with line 249 to be something like:

if let Ok(mut sealevel_payment) = self.get_payment_with_sequence(nonce.into()).await {
  // Comment explaining why we do this
  if sealevel_payment.igp_account_pubkey != self.igp.igp_account {
    sealevel_payment.gas_amount = U256::zero();
    sealevel_payment.payment = U256::zero();
  }
  payments.push((sealevel_payment.payment, sealevel_payment.log_meta));
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants