Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict WarpCore recipients to exclude remote router and collateral token #5057

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0x471
Copy link

@0x471 0x471 commented Dec 20, 2024

feat: restrict WarpCore recipients to exclude remote router and collateral token

Description

What's included in this PR?
In validateTransfer, checks to ensure that the recipient is not the destination router or token address

Drive-by changes

Are there any minor or drive-by changes also included?
No

Related issues

Backward compatibility

Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?
No

Testing

What kind of testing have these changes undergone?
None, for now.

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 176f9f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0x471 0x471 changed the title feat: restrict WarpCore recipients to exclude remote router and collateral token feat: restrict WarpCore recipients to exclude remote router and collateral token (#4964) Dec 20, 2024
@0x471 0x471 changed the title feat: restrict WarpCore recipients to exclude remote router and collateral token (#4964) feat: restrict WarpCore recipients to exclude remote router and collateral token Dec 20, 2024
@0x471 0x471 marked this pull request as draft December 20, 2024 12:15
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (a51b50c) to head (176f9f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5057   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

WarpCore shouldn't allow for recipients to be the remote router or remote collateral token
1 participant