feat(infra): added the getEthereumFormUSDTWarpConfig func #5056
Conversation
xeno097
requested review from
tkporter,
paulbalaji and
Mo-Hussain
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5056 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
There was a problem hiding this comment.
can I please request that every warp config/monitor PR to the monorepo is linked to a corresponding registry PR with the new config please, since we know that each new route here requires an updated .registryrc
it will make it easy to review two birds in one stone, a la new chain deploy PRs which reference both registry+monorepo PRs together
| tokens, | ||
| } from '../../../../../src/config/warp.js'; | ||
|
|
||
| const safeOwners: ChainMap<Address> = { |
There was a problem hiding this comment.
can you add a comment on who owns these
| form: '0x41B624412B529409A437f08Ef80bCabE81053650', | ||
| }; | ||
|
|
||
| export const getEthereumFormUSDCWarpConfig = async ( |
There was a problem hiding this comment.
would probably prefer us to split out these into their own files to stick with the pattern. We can ofc import the owners from one of them into the other
| routerConfig: ChainMap<RouterConfigWithoutOwner>, | ||
| ): Promise<ChainMap<HypTokenRouterConfig>> => { | ||
| const ethereum: HypTokenRouterConfig = { | ||
| mailbox: routerConfig.ethereum.mailbox, |
There was a problem hiding this comment.
can we do the
...routerConfig.ethereum,
...getOwnerConfigForAddress(safeOwners.ethereum),
pattern that we've been generally using instead of specifying mailbox and owner
Description
Adds the warp route config getter for the USDT route on Form network
associated registry PR hyperlane-xyz/hyperlane-registry#449
Drive-by changes
Backward compatibility
-YES
Testing