Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header frame with non-zero content-length and END_STREAM is malformed #813

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

eaufavor
Copy link
Contributor

Before this change, content-length underflow is only checked when receiving date frames.

This change adds similar check for headers frames.

@eaufavor eaufavor force-pushed the content-length-end-header branch from 7f1b98d to 86d07ab Compare November 11, 2024 19:54
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@seanmonstar
Copy link
Member

I'm fixing the MSRV job in #814.

Before this change, content-length underflow is only checked when
receiving date frames. The underflow error was never triggered if
data frames are never received.

This change adds similar check for headers frames.
@eaufavor eaufavor force-pushed the content-length-end-header branch from 86d07ab to 24a065f Compare November 11, 2024 21:58
@seanmonstar seanmonstar enabled auto-merge (squash) November 11, 2024 22:03
@seanmonstar seanmonstar merged commit 640db36 into hyperium:master Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants