-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbomodule + Bridgeless support #602
base: main
Are you sure you want to change the base?
Conversation
Wow this is huge 😅 Let me come back soon to review this. |
7b53063
to
b77f4d6
Compare
b77f4d6
to
820e5a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sektr63a I am having issue testing this PR
. I've posted the detailed error logs below. Could you kindly guide me how to test your PR
? I hope I can ship your hard work 🙏
Also would it be possible to upgrade the example
project to react-native 0.74.2
and not rc
version?
Thank you so much again for your effort!
Error Logs
Auto-linking React Native modules for target `rnaudiorecorderplayer`: RNAudioRecorderPlayer and rn-fetch-blob
Framework build type is static library
[Codegen] Adding script_phases to React-Codegen.
[Codegen] Generating ./build/generated/ios/React-Codegen.podspec.json
[!] Invalid `Podfile` file: [!] /Users/hyo/.nvm/versions/node/v20.13.1/bin/node ./../node_modules/react-native/scripts/generate-codegen-artifacts.js -p /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/ios/.. -o /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/ios -t ios
[Codegen] Analyzing /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/package.json
[Codegen] Searching for codegen-enabled libraries in the app.
[Codegen] The "codegenConfig" field is not defined in package.json. Assuming there is nothing to generate at the app level.
[Codegen] Searching for codegen-enabled libraries in the project dependencies.
[Codegen] Found react-native
[Codegen] Found react-native-audio-recorder-player
[Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js
[Codegen] Processing FBReactNativeSpec
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing rncore
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing RNAudioRecorderPlayerSpec
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios for RNAudioRecorderPlayerSpec
[Codegen] Done.
UnsupportedGenericParserError: Module NativeAudioRecorderPlayer: Unrecognized generic type 'AudioSet' in NativeModule spec.
at translateTypeReferenceAnnotation (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/typescript/modules/index.js:148:15)
at translateTypeAnnotation (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/typescript/modules/index.js:222:14)
at /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/parsers-commons.js:373:11
at guard (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/utils.js:26:14)
at translateFunctionTypeAnnotation (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/parsers-commons.js:367:25)
at buildPropertySchema (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/parsers-commons.js:484:7)
at /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/parsers-commons.js:705:24
at guard (/Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/utils.js:26:14)
at /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/node_modules/@react-native/codegen/lib/parsers/parsers-commons.js:702:14
at Array.map (<anonymous>) {
nodes: [
Node {
type: 'TSTypeReference',
start: 426,
end: 434,
loc: [SourceLocation],
typeName: [Node]
}
]
}
.
# from /Users/hyo/Github/hyochan/react-native-audio-recorder-player/Example/ios/Podfile:20
# -------------------------------------------
#
> use_react_native!(
# :path => config[:reactNativePath],
# -------------------------------------------
[!] [Codegen] warn: using experimental new codegen integration
What I did
- Install with yarn from root of the project.
- Navigate to
Example
and install packages with yarn. - Run
yarn ios
(Also triedpod update && pod install
).
Hello @hyochan I've just investigated the issue you faced. The main problem is with the types you added: There is some useful article about codegen type mapping. |
Thanks for coming back! I've just realized this! Thank you! |
hey folks, is there any updates on this PR now that react native 0.76 has landed? Thanks! |
This PR converts Native module to Turbomodule
Also updates Example project.