Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ios purchase #3

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix: ios purchase #3

merged 3 commits into from
Jul 25, 2024

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jul 25, 2024

Fix serialization error in discountOffer and target 13.4 in ios podspecc (setting to 15 won't let expo-module to load the library). Set example project ios target to version 15 which should be necessary since we are only supporting SK2.

test.mov

@hyochan hyochan added 🍗 enhancement New feature or request 📱 iOS Related to iOS 🛠 bugfix All kinds of bug fixes labels Jul 25, 2024
Copy link

Risk Level 2 - /home/runner/work/expo-iap/expo-iap/src/index.ts

  1. The import statement for NativeModulesProxy and EventEmitter from 'expo-modules-core' is correctly added, but ensure that these modules are necessary and used appropriately in the code.
  2. The removal of appAccountToken from iosTransactionToPurchaseMap might cause issues if this token is required elsewhere. Ensure that this change is intentional and does not break any functionality.
  3. The addition of appAccountToken in the requestPurchase function for iOS is appropriate, but ensure that this token is correctly handled and validated.
  4. The addition of offerToRecordIos and its usage in requestPurchase and requestSubscription functions improves the handling of offers. Ensure that the offer object is correctly formed and used.
  5. The change in the requestSubscription function to include andDangerouslyFinishTransactionAutomaticallyIOS and quantity is appropriate, but ensure that these parameters are correctly handled and do not introduce any side effects.
  6. The removal of the quantity default value in requestSubscription might cause issues if quantity is not provided. Ensure that this change is intentional and does not break any functionality.

🔍🛠️⚠️


Powered by Code Review GPT

@hyochan hyochan merged commit 08ad6b2 into main Jul 25, 2024
2 checks passed
@hyochan hyochan deleted the fix/ios-purchase branch July 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant