Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ios feature set #1

Merged
merged 6 commits into from
Jul 3, 2024
Merged

feat: ios feature set #1

merged 6 commits into from
Jul 3, 2024

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jul 3, 2024

No description provided.

hyochan added 4 commits June 3, 2024 01:32
getPendingTransactions, buyProdcut, sync, presentCodeRedemptionSheet, and events
@hyochan hyochan added 🎯 feature New feature 📱 iOS Related to iOS labels Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Risk Level 3 - /home/runner/work/expo-iap/expo-iap/example/android/app/src/main/java/com/dooboolab/test/MainActivity.kt

The removal of the onCreate method and other lifecycle methods may affect the app's behavior. Ensure that the new implementation correctly handles the app's lifecycle and that the setTheme method is called appropriately.


Risk Level 3 - /home/runner/work/expo-iap/expo-iap/example/android/app/src/main/java/com/dooboolab/test/MainApplication.kt

The changes in the MainApplication class involve significant restructuring. Ensure that the new ReactNativeHost and ApplicationLifecycleDispatcher are correctly initialized and that all necessary configurations are preserved.


Risk Level 3 - /home/runner/work/expo-iap/expo-iap/android/src/main/java/expo/modules/iap/ExpoIapModule.kt

The removal of comments reduces the clarity of the code for future developers. Consider keeping or updating comments to maintain code readability and documentation. Additionally, ensure that the sendEvent function is correctly defined and used within the context.


🛠️🔍📋


Powered by Code Review GPT

@hyochan hyochan merged commit 4144344 into main Jul 3, 2024
3 checks passed
@hyochan hyochan deleted the feat/ios branch July 3, 2024 16:52
@hyochan hyochan restored the feat/ios branch July 25, 2024 12:37
@hyochan hyochan deleted the feat/ios branch September 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 feature New feature 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant