Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs of ACF and featured media #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ixkaito
Copy link

@ixkaito ixkaito commented Sep 6, 2022

This PR fixes the following.

  • wp_make_content_images_responsive() is deprecated and the wp_make_content_images_responsive hook was removed.
    • Use wp_filter_content_tags() and the wp_filter_content_tags hook instead.
  • Fix ACF bug with repeater fields
    • We are using the wrong hook to get the value. We have to get the value before formatted and overwrite it after formatted via acf/format_value/type={$type}.
  • Fix bugs of saving featured images via REST API (i.e. Block Editor)
    • We have to use the rest_pre_insert_{$post_type} hook to get the featured image ID

- Update for core and
- Fix bugs of ACF Pro (or repeater field)
- Fix bugs of featured media
@ixkaito ixkaito mentioned this pull request Sep 6, 2022
@jonnyvaughan
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants