Fix Flux multiple Lora loading bug #10388
Open
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current approach of checking for a key with a
base_layer
suffix may lead to a bug when multiple Lora models are loaded. If the first loaded Lora model does not have weights for layern
, and the second one does, loading the second model will lead to an error since the transformer state dict currently does not have keyn.base_layer.weight
. So I explicitly check for the presence of a key with thebase_layer
suffix.@yiyixuxu