Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SANA LoRA] sana lora training tests and misc. #10296

Merged
merged 7 commits into from
Dec 23, 2024
Merged

[SANA LoRA] sana lora training tests and misc. #10296

merged 7 commits into from
Dec 23, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

  • Introduces a test suite for SANA LoRA fine-tuning.
  • Fixes the SANA LoRA tests and SANA pipeline tests to use Gemma2Model instead of Gemma2CausalLM.
  • Some QoL fixes to the SANA training script.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul requested a review from a-r-r-o-w December 19, 2024 05:36
a-r-r-o-w
a-r-r-o-w approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

examples/dreambooth/train_dreambooth_lora_sana.py Outdated Show resolved Hide resolved
tests/lora/test_lora_layers_sana.py Show resolved Hide resolved
@sayakpaul sayakpaul merged commit 76e2727 into main Dec 23, 2024
12 checks passed
@sayakpaul sayakpaul deleted the test-sana-lora-training branch December 23, 2024 07:05
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@sayakpaul @a-r-r-o-w
[SANA LoRA] sana lora training tests and misc. (#10296)
fb17ba3 
* sana lora training tests and misc.

* remove push to hub

* Update examples/dreambooth/train_dreambooth_lora_sana.py

Co-authored-by: Aryan <[email protected]>

---------

Co-authored-by: Aryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayakpaul @HuggingFaceDocBuilderDev @a-r-r-o-w