-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] ConsisID #10140
base: main
Are you sure you want to change the base?
[core] ConsisID #10140
Conversation
@a-r-r-o-w Do we need to create a branch of |
|
@a-r-r-o-w @HuggingFaceDocBuilderDev hi, I have add consisid to this branch, can you help us to reveiew the code? Is there anything else I missed?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
@a-r-r-o-w @hlky hi, what should I do next? |
Thanks @SHYuanBest. Please wait for further review from @yiyixuxu |
Thanks for working on this @SHYuanBest! The PR looks mostly good to me. There are some things I would like to test and maybe change. Looking into it now. I hope it would be okay if I push to this branch directly |
video = pipe(image=image, prompt=prompt, num_inference_steps=50, guidance_scale=6.0, use_dynamic_cfg=False, id_vit_hidden=id_vit_hidden, id_cond=id_cond, kps_cond=face_kps, generator=torch.Generator("cuda").manual_seed(42)) | ||
export_to_video(video.frames[0], "output.mp4", fps=8) | ||
``` | ||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any results being demonstrated should be linked from the huggingface documentation-images repository on HF Hub: https://huggingface.co/datasets/huggingface/documentation-images/tree/main/diffusers
If you could open a PR to their, I can merge it and then that could be linked here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, the pr is here https://huggingface.co/datasets/huggingface/documentation-images/discussions/406
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-r-r-o-w @sayakpaul I have revised the PR, could you help to merge?
https://huggingface.co/datasets/huggingface/documentation-images/discussions/406
@@ -0,0 +1,845 @@ | |||
# Copyright 2024 ConsisID Authors and The HuggingFace Team. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiyixuxu So this model is mostly similar to CogVideoX except for performing cross attention with the face embeddings. I see some usages of nn.Sequential's that we don't like to have in Diffusers. Should we do the conversions and have a conversion script?
to do:
|
@SHYuanBest Great work on the changes! We will try and integrate this soon and target it for next diffusers release (we have one this week, which is why we've been very busy). On your end, I think we are mostly good with the changes, and just need to address some minor concerns for diffusers-side integration. I will let YiYi comment and do her review first and then we can tackle the remaining things |
@a-r-r-o-w @yiyixuxu That's great, much thanks for your great support! Looking forward to merge. |
What does this PR do?
Add support for ConsisID (#10100)
Paper: https://arxiv.org/abs/2411.17440
Project: https://pku-yuangroup.github.io/ConsisID
Code: https://github.com/PKU-YuanGroup/ConsisID
Demo: https://huggingface.co/spaces/BestWishYsh/ConsisID-preview-Space
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.