[Common Voice] Make sure bytes are correctly deleted if path exists
#4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
cool that you noticed that we store unnecessary bytes again :D |
| @@ -792,8 +792,9 @@ def _generate_examples(self, local_extracted_archive, archive_iterator, metadata | |||
| result = {key: value for key, value in zip(data_fields, field_values)} | |||
|
|
|||
| # set audio feature | |||
| path = os.path.join(local_extracted_archive, path) if local_extracted_archive else path | |||
| result["audio"] = {"path": path, "bytes": f.read()} | |||
There was a problem hiding this comment.
maybe to be clearer and not to read bytes when it's non needed even smth like
result["audio"] = {"path": path, "bytes": f.read() if not local_extracted_archive else None}
or
result["audio"] = {"path": path}
if not local_extracted_archive:
result["audio"]["bytes"] = f.read()
?
not sure that it's clearer that way though
There was a problem hiding this comment.
I would keep as it is right now.
Reading the bytes doesn't cost anything, since they are actually already in memory from iter_archive. And bytes are discarded if the path is a local path to avoid duplicating data already (see #4187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathshould be set to local path inside audio feature if exist so that bytes can correctly be deleted.