Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document save_to_disk and push_to_hub on images and audio files #4193

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Document save_to_disk and push_to_hub on images and audio files #4193

merged 2 commits into from
Apr 22, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Apr 21, 2022

Following #4187, I explained in the documentation of save_to_disk and push_to_hub how they handle image and audio data.

@lhoestq lhoestq requested a review from mariosasko April 21, 2022 09:04
@lhoestq lhoestq mentioned this pull request Apr 21, 2022
Merged
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq mentioned this pull request Apr 21, 2022
Merged
@albertz albertz mentioned this pull request Apr 21, 2022
Open
mariosasko
mariosasko reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

src/datasets/arrow_dataset.py Outdated Show resolved Hide resolved
src/datasets/dataset_dict.py Outdated Show resolved Hide resolved
@lhoestq
Copy link
Member Author

lhoestq commented Apr 21, 2022

Good catch, I updated the docstrings

mariosasko
mariosasko approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now.

@lhoestq lhoestq merged commit bf43201 into master Apr 22, 2022
@lhoestq lhoestq deleted the document-save_to_disk-with-image-and-audio branch April 22, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosasko mariosasko mariosasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhoestq @HuggingFaceDocBuilderDev @mariosasko