-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial feature add #1986
base: main
Are you sure you want to change the base?
initial feature add #1986
Conversation
private boolean compareUsePaginatedCommits; | ||
|
||
private Set<GHRepositoryCustomProperty> custom_properties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts: I'm not sure that Set
helps you here. You might want to represent this as
List
- getting all of themMap<String, String>
- the docs seem to indicate that you can't have multiple properties with the samename
value on a repository or organization. And the properties are just name/value pairs...Map<String,CustomProperty>
- This might be a good choice for future proofing, in case GitHub decides to make CustomProperty records more complex in future.
For either of the Map
options you need to check whether key
value uniqueness case-insensitive, case-sensitive but restricted to ASCII, or literary any Unicode/UTF-8 String.
I mean this as a discussion. I'm fully open to changing my mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got my custom properties returned to me using this code base referenced in a console app.
I was discussing map options with a friend of mine but haven't been able to get it to work yet. I am not familiar with how this repo handles object mapping and kept running into null errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Jackson.
Give an example of where you get null errors and we'll see if we can figure it out.
Looks reasonable. Only one comment so far. |
Description
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: