Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable site for v2.x #1939

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Re-enable site for v2.x #1939

merged 2 commits into from
Sep 17, 2024

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@bitwiseman bitwiseman force-pushed the feature/ci-site branch 2 times, most recently from c36b470 to e98ab11 Compare September 17, 2024 07:47
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 97.06667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (7807501) to head (9419cd9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/org/kohsuke/github/GHBranchProtection.java 91.66% 2 Missing ⚠️
src/main/java/org/kohsuke/github/GHEmail.java 0.00% 2 Missing ⚠️
src/main/java/org/kohsuke/github/GHInvitation.java 0.00% 2 Missing ⚠️
...va/org/kohsuke/github/GHPullRequestFileDetail.java 0.00% 2 Missing ⚠️
...ain/java/org/kohsuke/github/GHRequestedAction.java 0.00% 2 Missing ⚠️
src/main/java/org/kohsuke/github/GHMyself.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1939      +/-   ##
============================================
+ Coverage     82.61%   82.99%   +0.38%     
  Complexity     2323     2323              
============================================
  Files           231      231              
  Lines          6977     7164     +187     
  Branches        376      376              
============================================
+ Hits           5764     5946     +182     
- Misses          975      980       +5     
  Partials        238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman marked this pull request as draft September 17, 2024 08:49
@bitwiseman bitwiseman marked this pull request as ready for review September 17, 2024 16:47
@bitwiseman bitwiseman merged commit a9fa45c into hub4j:main Sep 17, 2024
12 checks passed
@bitwiseman bitwiseman deleted the feature/ci-site branch September 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant