Axe automated header generation. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevweiss
force-pushed
the
noheadergen
branch
from
53f6288 to
7caea27
Compare
|
Please remove |
bertwesarg
reviewed
Sep 2, 2020
Comment on lines
-61
to
+57
| myhtopplatsources = linux/Platform.c linux/IOPriorityPanel.c linux/IOPriority.c \ | ||
| myhtopplatsources = linux/Platform.c linux/IOPriorityPanel.c \ |
There was a problem hiding this comment.
Why was linux/IOPriority.c removed?
There was a problem hiding this comment.
Because aside from being a source from which the corresponding header was generated, it included nothing of actual substance -- an enum declaration, a few macros, and a typedef (zero variable or function definitions).
There was a problem hiding this comment.
sorry, missed, that the .c file was removed in reallity too.
|
Agreed re: |
|
The extra targets in Maybe the |
zevweiss
force-pushed
the
noheadergen
branch
from
822154a to
a1fe289
Compare
|
Ah, good point -- and also |
Reasoning: - implementation was unsound -- broke down when I added a fairly basic macro definition expanding to a struct initializer in a *.c file. - made it way too easy (e.g. via otherwise totally innocuous git commands) to end up with timestamps such that it always ran MakeHeader.py but never used its output, leading to overbuild noise when running what should be a null 'make'. - but mostly: it's just an awkward way of dealing with C code.
Applied via:
$ find * -name '*.h' -exec sed -i -r 's/^extern (.+\()/\1/;' {} +
Suggested-by: Bert Wesarg <[email protected]>
zevweiss
force-pushed
the
noheadergen
branch
from
a1fe289 to
7758ffc
Compare
|
Rebased to resolve merge conflicts; also added a tiny commit to remove a duplicate declaration introduced in #86. |
hugomg
added a commit
to hugomg/htop
that referenced
this pull request
Sep 12, 2020
PR htop-dev#70 got rid of the infrastructure for generating header files, but it left behind some code duplication. Some of cases are things that belong in the header file and don't need to be reapeated in the C file. Other cases are things that belong in the C file and don't need to be in the header file. In this commit I tried to fix most of these that I could find. When given a choice I preferred keeping things out of the header file, unless they were being used by someone else.
hugomg
added a commit
to hugomg/htop
that referenced
this pull request
Sep 12, 2020
PR htop-dev#70 got rid of the infrastructure for generating header files, but it left behind some code duplication. Some of cases are things that belong in the header file and don't need to be repeated in the C file. Other cases are things that belong in the C file and don't need to be in the header file. In this commit I tried to fix all of these that I could find. When given a choice I preferred keeping things out of the header file, unless they were being used by someone else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
implementation was unsound -- broke down when I added a fairly
basic macro definition expanding to a struct initializer in a *.c
file.
made it way too easy (e.g. via otherwise totally innocuous git
commands) to end up with timestamps such that it always ran
MakeHeader.py but never used its output, leading to overbuild noise
when running what should be a null 'make'.
but mostly: it's just an awkward way of dealing with C code.
[Addresses #9.]