Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenXR - Remove non-functional Vulkan implementation #19766

Merged
merged 2 commits into from
Dec 26, 2024
Merged

OpenXR - Remove non-functional Vulkan implementation #19766

merged 2 commits into from
Dec 26, 2024
+52 −237

Conversation

lvonasek
Copy link
Contributor

I never made the Vulkan VR integration working. I decided to cleanup the non-functional code.

@sum2012 sum2012 added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Dec 26, 2024
hrydgard
hrydgard approved these changes Dec 26, 2024
View reviewed changes
Copy link
Owner

@hrydgard hrydgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, can always revert this if me or anyone else later wants to work on it.

@hrydgard hrydgard added this to the v1.19.0 milestone Dec 26, 2024
@hrydgard hrydgard merged commit d1f8b78 into hrydgard:master Dec 26, 2024
19 checks passed
@lvonasek lvonasek deleted the cleanup-openxr-vulkan branch December 26, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrydgard hrydgard hrydgard approved these changes

Assignees
No one assigned
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes.
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lvonasek @hrydgard @sum2012