Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydaikin version #79761

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Bump pydaikin version #79761

merged 1 commit into from
Oct 6, 2022

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented Oct 6, 2022

Proposed change

Bump Daikin version, change log: https://bitbucket.org/mustang51/pydaikin/branches/compare/v2.7.2%0Dv2.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode merged commit eb19927 into home-assistant:dev Oct 6, 2022
@thecode
Copy link
Member

thecode commented Oct 6, 2022

Should we add t his to the 2022.10.2 milestone?

@fredrike fredrike deleted the bump-pydaikin branch October 7, 2022 04:54
@fredrike
Copy link
Contributor Author

fredrike commented Oct 7, 2022

Should we add t his to the 2022.10.2 milestone?

Yes, please do that.

@thecode thecode added this to the 2022.10.2 milestone Oct 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daikin AC Unexpected error creating device when the wifi SSID contains a comma
5 participants