Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onvif-zeep-async to 3.1.13 #132229

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jterrace
Copy link
Contributor

@jterrace jterrace commented Dec 4, 2024

Proposed change

Bump onvif-zeep-async to 3.1.13.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The main reason for updating is to pull in openvideolibs/python-onvif-zeep-async#54, which fixes using push notifications with some Tapo cameras that weren't compatible with the onvif XML being sent. The rest of the changes are maintenance updates.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco changed the title Bump onvif-zeep-async to 3.1.13. Bump onvif-zeep-async to 3.1.13 Dec 4, 2024
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Dec 4, 2024
@bdraco
Copy link
Member

bdraco commented Dec 4, 2024

Looks like the CI is failing due to an unrelated issue. #132234

@MartinHjelmare MartinHjelmare merged commit ce11ac5 into home-assistant:dev Dec 4, 2024
60 of 61 checks passed
@jterrace jterrace deleted the bump-onvif-dep branch December 4, 2024 12:37
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: onvif Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants