acknowledge review points

crates/milo/Cargo.toml

@@ -2,6 +2,7 @@
 name = "milo"
 version = "0.1.0"
 edition = "2021"
+publish = false
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

crates/milo/src/ark.rs

@@ -7,14 +7,13 @@ pub mod amp;
 pub mod freq;
 
 pub enum ArkTypes {
-    Empty,
     FreqArk(freq::FreqArchive),
     AmpArk(amp::AmpArchive),
 }
 
 pub fn load_ark_file(f: &mut File) -> Result<ArkTypes, Box<dyn Error>> {
     let vercheck = read_u32(f, true)?;
-    let mut ark: ArkTypes = ArkTypes::Empty;
+    let ark: ArkTypes;
     match vercheck {
         0x004B5241 => {
             let mut freq = freq::FreqArchive::new();
@@ -26,7 +25,10 @@ pub fn load_ark_file(f: &mut File) -> Result<ArkTypes, Box<dyn Error>> {
             amp.load(f, 0)?;
             ark = ArkTypes::AmpArk(amp);
         }
-        _ => println!("unrecognized ark version. if gh1 or later, use the .hdr and not the .ark")
+        _ => {
+            println!("unrecognized ark version. if gh1 or later, use the .hdr and not the .ark");
+            return Err::<_, Box<dyn Error>>("unkver".into());
+        }
     }
     Ok(ark)
 }

crates/milo/src/ark/amp.rs

@@ -1,4 +1,5 @@
 use std::fmt::{Formatter, Display};
+use std::error::Error;
 
 use crate::traits::Load;
 use crate::fio;
@@ -72,7 +73,7 @@ impl AmpArchive {
 }
 
 impl Load for AmpArchive {
-    fn load(&mut self, f: &mut std::fs::File, _: u32) -> Result<(), Box<dyn std::error::Error>> {
+    fn load(&mut self, f: &mut std::fs::File, _: u32) -> Result<(), Box<dyn Error>> {
         self.version = fio::read_u32(f, true)?;
         self.entry_ct = fio::read_u32(f, true)?;
         for _ in 0..self.entry_ct {
@@ -113,29 +114,3 @@ impl Display for AmpArchive {
         Ok(())
     }
 }
-
-impl Clone for AmpArchive {
-    fn clone(&self) -> Self {
-        let mut new_entries: Vec<AmpFileEntry> = vec![];
-        for entry in &self.entries {
-            new_entries.push(*entry);
-        }
-        let mut new_strtbl: Vec<String> = vec![];
-        for string in &self.string_table {
-            new_strtbl.push(string.clone());
-        }
-        let mut new_stridxs: Vec<u32> = vec![];
-        for idx in &self.string_idx_entries {
-            new_stridxs.push(*idx);
-        }
-        Self {
-            version: self.version,
-            entry_ct: self.entry_ct,
-            entries: new_entries,
-            str_table_size: self.str_table_size,
-            string_table: new_strtbl,
-            string_idx_count: self.string_idx_count,
-            string_idx_entries: new_stridxs
-        }
-    }
-}