generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrollbars, popup and dataset and component init #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes changed listeners by cleanDataset
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
…without component.ini()
infloent
changed the title
Fix scrollbars
Fix scrollbars, popup and dataset and component init
Aug 9, 2024
FelipeSimoes
approved these changes
Aug 19, 2024
; Conflicts: ; scripts/libs.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs:
Fixes the scrollbars on windows
Fixes the popup and due to the changes for external config the support for https://github.com/hlxsites/henkel-raqn-guide/blob/main/blocks/popup/config-popup.md had to be removed.
We will need a separate ticket to find another way to add config the popup
To fix the popup some general fixes were applied to component base:
applyData()
to prevent double trigger of attribute change listenersattributesValues.all
if the element already has data attributes added beforethis.init()
orthis.initOnConnected()
are run;test page for popup - all will be modals no more flyout due to the removal of the popup-config.