Fixed lint issues

hlxsites · Dec 11, 2024 · 04b8f2d · 04b8f2d
1 parent 4f849b3
commit 04b8f2d
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/blocks/card-list/card-list.js b/blocks/card-list/card-list.js
@@ -2,23 +2,23 @@ import ffetch from '../../scripts/ffetch.js';
 import {
   ul, a, div, span,
 } from '../../scripts/dom-builder.js';
-
-let tag = getMetadata('template') === 'wsaw' ? 'solutions' : 'topics';
 import { getMetadata, toClassName } from '../../scripts/lib-franklin.js';
 import createArticleCard from './articleCard.js';
 import createLibraryCard from './libraryCard.js';
 import createApplicationCard from './applicationCard.js';
 import { makePublicUrl } from '../../scripts/scripts.js';
 import { buildItemListSchema } from '../../scripts/schema.js';
 
-const getSelectionFromUrl = () => (window.location.pathname.indexOf(tag) > -1 ? toClassName(window.location.pathname.replace('.html', '').split('/').pop()) : '');
+const tagName = getMetadata('template') === 'wsaw' ? 'solutions' : 'topics';
+
+const getSelectionFromUrl = () => (window.location.pathname.indexOf(tagName) > -1 ? toClassName(window.location.pathname.replace('.html', '').split('/').pop()) : '');
 const getPageFromUrl = () => toClassName(new URLSearchParams(window.location.search).get('page')) || '';
 
 const createTopicUrl = (currentUrl, keyword = '') => {
-  if (currentUrl.indexOf(tag) > -1) {
+  if (currentUrl.indexOf(tagName) > -1) {
     return currentUrl.substring(0, currentUrl.lastIndexOf('/') + 1) + toClassName(keyword).toLowerCase();
   }
-  return `${currentUrl.replace('.html', '')}/${tag}/${toClassName(keyword).toLowerCase()}`;
+  return `${currentUrl.replace('.html', '')}/${tagName}/${toClassName(keyword).toLowerCase()}`;
 };
 
 const patchBannerHeading = () => {
@@ -84,7 +84,7 @@ const createPagination = (entries, page, limit) => {
 
 export function createFilters(articles, viewAll = false) {
   // collect tag filters
-  const allKeywords = articles.map((item) => item[tag].replace(/,\s*/g, ',').split(','));
+  const allKeywords = articles.map((item) => item[tagName].replace(/,\s*/g, ',').split(','));
   const keywords = new Set([].concat(...allKeywords));
   keywords.delete('');
   keywords.delete('Blog'); // filter out generic blog tag
@@ -93,8 +93,8 @@ export function createFilters(articles, viewAll = false) {
   // render tag cloud
   const newUrl = new URL(window.location);
   newUrl.searchParams.delete('page');
-  if (window.location.pathname.indexOf(tag) > -1) {
-    newUrl.pathname = window.location.pathname.substring(0, window.location.pathname.indexOf(`/${tag}/`));
+  if (window.location.pathname.indexOf(tagName) > -1) {
+    newUrl.pathname = window.location.pathname.substring(0, window.location.pathname.indexOf(`/${tagName}/`));
   }
   const tags = viewAll ? div(
     { class: 'flex flex-wrap gap-2 gap-y-0 mb-4' },
@@ -139,7 +139,7 @@ export function createFilters(articles, viewAll = false) {
   });
 
   // patch banner heading with selected tag only on topics pages
-  if (getMetadata('heading') && window.location.pathname.indexOf(tag) > -1) {
+  if (getMetadata('heading') && window.location.pathname.indexOf(tagName) > -1) {
     patchBannerHeading();
   }
 
@@ -162,7 +162,7 @@ export default async function decorate(block) {
   const activeTagFilter = block.classList.contains('url-filtered') ? getSelectionFromUrl() : '';
   if (activeTagFilter) {
     filteredArticles = articles.filter(
-      (item) => toClassName(item[tag]).toLowerCase().indexOf(activeTagFilter) > -1,
+      (item) => toClassName(item[tagName]).toLowerCase().indexOf(activeTagFilter) > -1,
     );
   }
   buildItemListSchema(filteredArticles, 'resources');