-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PDP events #68
Add PDP events #68
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the schema, productId
should be a number, not a string. Is there a way to customize the canonicalUrl
? As in the context of Edge Delivery the canonical URL is usually different than what's returned by the API.
@herzog31 What do you mean by customizing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
@@ -260,6 +249,7 @@ export default async function decorate(block) { | |||
}); | |||
}, | |||
}, | |||
useACDL: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that ACDL is on opt-in only basis? I thought it was implemented OOTB in all dropins. Is this a pattern we should follow for all other dropins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think this should be a pattern followed in the other dropins, and eventually I might even remove it from the PDP dropin.
I had to add this because I have no control of how/when Bulk will update the PDP version and they are already handling the data collection on the product details block directly and I didn't want to interfere with that.
product page view
eventproduct
contextPlease always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:
https://pdp-acdl--aem-boilerplate-commerce--hlxsites.hlx.live/products/abominable-hoodie/MH09