Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDP events #68

Merged
merged 13 commits into from
Jun 28, 2024
Merged

Add PDP events #68

merged 13 commits into from
Jun 28, 2024

Conversation

alandana
Copy link
Collaborator

@alandana alandana commented Jun 17, 2024

  • upgrade to PDP v0.2.3-alpha7 which has support for ACDL integration
    • product page view event
    • product context
  • upgrade to dropins tools v0.25.0

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Copy link

aem-code-sync bot commented Jun 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 17, 2024

Copy link

@herzog31 herzog31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the schema, productId should be a number, not a string. Is there a way to customize the canonicalUrl? As in the context of Edge Delivery the canonical URL is usually different than what's returned by the API.

image

@alandana
Copy link
Collaborator Author

According to the schema, productId should be a number, not a string. Is there a way to customize the canonicalUrl? As in the context of Edge Delivery the canonical URL is usually different than what's returned by the API.

image

@herzog31 What do you mean by customizing the canonicalURL? From the dropin or from EDS?
I realized I mapped the canonicalUrl to urlKey, but the API response also provides url. Would that be better?

Copy link

@herzog31 herzog31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@alandana alandana merged commit 52f17c9 into main Jun 28, 2024
2 checks passed
@alandana alandana deleted the pdp-acdl branch June 28, 2024 07:02
@@ -260,6 +249,7 @@ export default async function decorate(block) {
});
},
},
useACDL: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that ACDL is on opt-in only basis? I thought it was implemented OOTB in all dropins. Is this a pattern we should follow for all other dropins?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think this should be a pattern followed in the other dropins, and eventually I might even remove it from the PDP dropin.
I had to add this because I have no control of how/when Bulk will update the PDP version and they are already handling the data collection on the product details block directly and I didn't want to interfere with that.

dpatil-magento added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants