Merge branch 'main' into pdp-404

hlxsites · Jul 12, 2024 · 555f8d0 · 555f8d0
2 parents 6a59afa + fe8d9c9
commit 555f8d0
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 11 deletions.
diff --git a/blocks/product-details/product-details.js b/blocks/product-details/product-details.js
@@ -200,9 +200,11 @@ export default async function decorate(block) {
         await productRenderer.render(ProductDetails, {
           sku: getSkuFromUrl(),
           carousel: {
-            controls: 'thumbnailsColumn',
+            controls: {
+              desktop: 'thumbnailsColumn',
+              mobile: 'thumbnailsRow',
+            },
             arrowsOnMainImage: true,
-            mobile: true,
             peak: {
               mobile: true,
               desktop: false,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
   "dependencies": {
     "@adobe/magento-storefront-event-collector": "^1.8.0",
     "@adobe/magento-storefront-events-sdk": "^1.8.0",
-    "@dropins/storefront-pdp": "^0.2.3-alpha7",
+    "@dropins/storefront-pdp": "^0.3.0",
     "@dropins/tools": "^0.25.0"
   }
 }
diff --git a/scripts/__dropins__/storefront-pdp/containers/ProductDetails.js b/scripts/__dropins__/storefront-pdp/containers/ProductDetails.js
diff --git a/scripts/__dropins__/storefront-pdp/containers/ProductDetails/ProductDetails.d.ts b/scripts/__dropins__/storefront-pdp/containers/ProductDetails/ProductDetails.d.ts
@@ -15,13 +15,15 @@ type DefaultSlotContext = {
     valid: boolean;
 };
 export type CarouselConfig = {
-    mobile?: boolean;
-    controls?: 'thumbnailsRow' | 'thumbnailsColumn' | 'dots' | null;
+    controls?: {
+        desktop?: 'thumbnailsRow' | 'thumbnailsColumn' | 'dots' | null;
+        mobile?: 'dots' | 'thumbnailsRow' | null;
+    };
     arrowsOnMainImage?: boolean;
     loopable?: boolean;
     peak?: {
-        mobile: boolean;
         desktop: boolean;
+        mobile: boolean;
     };
     gap?: 'small' | 'medium' | 'large' | null;
     thumbnailsLoadingMode?: 'lazy' | 'eager';