Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test Coverage Part 1 #208

Merged
merged 6 commits into from
Nov 18, 2024
Merged

E2E Test Coverage Part 1 #208

merged 6 commits into from
Nov 18, 2024

Conversation

pglombardo
Copy link
Collaborator

@pglombardo pglombardo commented Oct 28, 2024

Description

In the ramp up to v1, we are putting in thorough E2E tests to cover all parts of the protocol and client.

Besides extended tests, this PR includes the following fixes:

  1. Fix DecodeUTF8String to properly handle response strings up to 65535 in length
  2. Add DisconnectOptionsBuilder and support all options for MQTT v5 Disconnect
  3. More limits checking on things such as Client ID length and other passed in options.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo changed the title E2E Test Coverage E2E Test Coverage Part 1 Nov 8, 2024
@pglombardo pglombardo added bug Something isn't working enhancement New feature or request labels Nov 18, 2024
@pglombardo pglombardo merged commit e935d2a into main Nov 18, 2024
8 checks passed
@pglombardo pglombardo deleted the plan-tests branch November 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant