Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: More Reliable LWT Tests #125

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Tests: More Reliable LWT Tests #125

merged 6 commits into from
Feb 2, 2024

Conversation

pglombardo
Copy link
Collaborator

@pglombardo pglombardo commented Feb 2, 2024

Description

The Github tests occasionally flake out on the Last will and testament tests. This PR increases the interval a bit to make sure we don't miss the LWT message.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo changed the title Tests: Increate LWT delay interval Tests: Increase LWT delay interval Feb 2, 2024
@pglombardo pglombardo changed the title Tests: Increase LWT delay interval Tests: More Reliable LWT Tests Feb 2, 2024
@pglombardo pglombardo merged commit 11c6013 into main Feb 2, 2024
5 checks passed
@pglombardo pglombardo deleted the fix-github-lwt branch February 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant