Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ratelimit_per_user field from create_news_channel #2079

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

syncblaze
Copy link
Contributor

Summary

Removed ratelimit_per_user field from create_news_channel since news channels dont have a ratelimit field

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@Le0Developer
Copy link
Contributor

since news channels dont have a ratelimit field

they do though...

Screen.Recording.2024-10-16.at.12.38.22.mov

Besides the "janky" way of setting them using the normal client, they work as normal.

@syncblaze
Copy link
Contributor Author

since news channels dont have a ratelimit field

they do though...

Besides the "janky" way of setting them using the normal client, they work as normal.

Well are u sure the ratelimit affects users if the channel is set as news channel?

If so, then it would be needed to add the ratelimit field to the GuildNewsChannel.

@Le0Developer
Copy link
Contributor

Well are u sure the ratelimit affects users if the channel is set as news channel?

yep
image

@syncblaze
Copy link
Contributor Author

Well are u sure the ratelimit affects users if the channel is set as news channel?

yep

then my bad, do you know if the ratelimit field is sent in the news channel payload?

Ig it should be sent, that means i will add the ratelimit field to the NewsChannel class in the next hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants