Skip to content

Commit

Permalink
Include note about console output of translations
Browse files Browse the repository at this point in the history
  • Loading branch information
Stefanni Brasil authored Jun 28, 2024
1 parent 0812ef0 commit 3eaedf4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ faker-ruby already has lots of generators and locales. We appreciate any efforts
- updating the existing translations
- fixing any outdated/wrong translations

> [!NOTE]
> Please include the console output of the translations in the PR description. Run `bundle exec rake console` to confirm the translations are working as expected. [Here's an example](https://github.com/faker-ruby/faker/pull/2960#issuecomment-2159698291).
Although we maintain Faker in our free time, we try to respond to contributions in a timely manner. Once we look at your pull request, we may give you feedback. For instance, we may suggest some changes to make to your code to fit within the project style or discuss alternate ways of addressing the issue in question. Assuming we're happy with everything, we'll then bring your changes into main. Now you're a contributor!

## Setting up your environment
Expand Down

0 comments on commit 3eaedf4

Please sign in to comment.