New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup derivations #1106

Merged

pavpanchekha merged 2 commits into cleanup-datafile from cleanup-derivations

Dec 24, 2024

Contributor

pavpanchekha commented Dec 23, 2024

This PR moves get-canon-rule-name to happen entirely inside egg-parsed->expr, which has two advantages:

This ugly part of the egg-herbie library is hidden from callers
The derivations package skips making a whole unnecessary copy of the proof

pavpanchekha added 2 commits

December 22, 2024 21:38


          Minor simplifications to derivations

f905ef1


          Canonicalize rule names in the right place

ccb8a28

Base automatically changed from cleanup-taylor to cleanup-datafile

December 24, 2024 00:21

pavpanchekha merged commit ebb2989 into cleanup-datafile

6 checks passed

pavpanchekha deleted the cleanup-derivations branch

December 24, 2024 00:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet