Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve artifactory response validations #52

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Improve artifactory response validations #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28b30e5
do not accept redirect in ping check
asmello Sep 14, 2023
533e941
actually fix install command
asmello Sep 14, 2023
a4d1d44
validate mime type of download requests
asmello Sep 14, 2023
bfedbc2
Merge branch 'main' into amello/auth-validation
asmello Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions src/registry/artifactory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ impl Artifactory {
url
};

let response = reqwest::Client::new()
let response = reqwest::Client::builder()
.redirect(reqwest::redirect::Policy::none())
.build()
.wrap_err("client error")?
.get(repositories_uri.clone())
.header(
"X-JFrog-Art-Api",
Expand Down Expand Up @@ -88,7 +91,10 @@ impl Registry for Artifactory {
url
};

let response = reqwest::Client::new()
let response = reqwest::Client::builder()
.redirect(reqwest::redirect::Policy::none())
.build()
.wrap_err("client error")?
.get(artifact_uri.clone())
.header(
"X-JFrog-Art-Api",
Expand All @@ -97,6 +103,21 @@ impl Registry for Artifactory {
.send()
.await?;

ensure!(
response.status() != 302,
"Remote server attempted to redirect request - is the Artifactory URL valid?"
);

let headers = response.headers();
let content_type = headers
.get(&reqwest::header::CONTENT_TYPE)
.wrap_err("missing header in response")?;

ensure!(
content_type == reqwest::header::HeaderValue::from_static("application/x-gzip"),
"Server response has incorrect mime type: {content_type:?}"
);

ensure!(
response.status().is_success(),
"Failed to fetch {dependency}: {}",
Expand All @@ -123,7 +144,10 @@ impl Registry for Artifactory {
.parse()
.wrap_err("Failed to construct artifact uri")?;

let response = reqwest::Client::new()
let response = reqwest::Client::builder()
.redirect(reqwest::redirect::Policy::none())
.build()
.wrap_err("client error")?
.put(artifact_uri.clone())
.header(
"X-JFrog-Art-Api",
Expand All @@ -134,6 +158,11 @@ impl Registry for Artifactory {
.await
.wrap_err("Failed to upload release to artifactory")?;

ensure!(
response.status() != 302,
"Remote server attempted to redirect publish request - is the Artifactory URL valid?"
);

ensure!(
response.status().is_success(),
"Failed to publish {}: {}",
Expand Down