improve consistency for manifest to/from string

src/manifest.rs

@@ -24,8 +24,8 @@ impl From<Manifest> for RawManifest {
     fn from(manifest: Manifest) -> Self {
         let dependencies: DependencyMap = manifest
             .dependencies
-            .iter()
-            .map(|dep| (dep.package.to_owned(), dep.manifest.to_owned()))
+            .into_iter()
+            .map(|dep| (dep.package, dep.manifest))
             .collect();
 
         Self {
@@ -78,11 +78,6 @@ impl Manifest {
             .await
             .wrap_err("Failed to write manifest")
     }
-
-    pub fn as_toml(&self) -> eyre::Result<String> {
-        toml::to_string_pretty(&RawManifest::from(self.clone()))
-            .wrap_err("failed to render manifest as TOML")
-    }
 }
 
 impl From<RawManifest> for Manifest {
@@ -111,6 +106,14 @@ impl TryFrom<String> for Manifest {
     }
 }
 
+impl TryInto<String> for Manifest {
+    type Error = toml::ser::Error;
+
+    fn try_into(self) -> Result<String, Self::Error> {
+        toml::to_string_pretty(&RawManifest::from(self))
+    }
+}
+
 /// Manifest format for api packages
 #[derive(Debug, Clone, Hash, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct PackageManifest {

src/package.rs

@@ -149,10 +149,13 @@ impl PackageStore {
 
         let mut archive = tar::Builder::new(Vec::new());
 
-        let manifest_bytes = manifest
-            .as_toml()
-            .wrap_err("Failed to encode release manifest")?
-            .into_bytes();
+        let manifest_bytes = {
+            let as_str: String = manifest
+                .clone()
+                .try_into()
+                .wrap_err("failed to render manifest as TOML")?;
+            as_str.into_bytes()
+        };
 
         let mut header = tar::Header::new_gnu();
         header.set_size(