Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction status checks to examples #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

theekrystallee
Copy link
Member

@theekrystallee theekrystallee commented Dec 31, 2024

this PR enhances the examples with transaction status checks, clear success/failure logging, and error handling

hcs/script-hcs-topic.js Outdated Show resolved Hide resolved
hcs/script-hcs-topic.js Show resolved Hide resolved
@@ -99,7 +91,7 @@ async function scriptHtsFungibleToken() {

// NOTE: Verify token using Mirror Node API
await logger.logSection('Get token data from the Hedera Mirror Node');
const tokenVerifyMirrorNodeApiUrl = `https://testnet.mirrornode.hedera.com/api/v1/tokens/${tokenId.toString()}`;
const tokenVerifyMirrorNodeApiUrl = `https://testnet.mirrornode.hedera.com/api/v1/tokens/${tokenCreateTxReceipt.tokenId.toString()}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move tokenId out of its current if block, and use that here instead.

.setTokenType(TokenType.FungibleCommon)
// Configure token options: name, symbol, decimals, initial supply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for removing these comments?
they were added/ requested by @SimiHunjan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if comments were removed, it wasnt intentional. the only part of the code I meant to update were the lines adding the transaction status checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants