Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TSV line numbers to TSV-related issue messages #144

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Add TSV line numbers to TSV-related issue messages #144

merged 5 commits into from
Mar 29, 2024

Conversation

happy5214
Copy link
Member

This PR will eventually add line numbers for issues related to BIDS TSV files to their respectively generated issue messages and objects. They will be pulled from either the BidsTsvEvent/BidsTsvRow object or injected during HED column validation.

Fixes #59

@happy5214 happy5214 added enhancement New feature or request help wanted Extra attention is needed bids BIDS integration labels Mar 15, 2024
@happy5214 happy5214 added this to the 3.14.0 milestone Mar 15, 2024
@happy5214 happy5214 self-assigned this Mar 15, 2024
@happy5214 happy5214 changed the title [WIP] Add TSV line numbers to TSV-related issue messages Add TSV line numbers to TSV-related issue messages Mar 29, 2024
@happy5214 happy5214 requested a review from VisLab March 29, 2024 14:59
@happy5214 happy5214 added the tests Issues related to testcases label Mar 29, 2024
VisLab
VisLab approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code walk through during meeting resulted in a slight refactoring to eliminate duplicate code. Good to go.

@happy5214 happy5214 marked this pull request as ready for review March 29, 2024 15:31
@happy5214 happy5214 merged commit 2d3cc74 into master Mar 29, 2024
6 of 7 checks passed
@happy5214 happy5214 deleted the add-tsv-line-to-issues branch March 29, 2024 15:31
@happy5214 happy5214 modified the milestones: 3.14.0, 3.13.5 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VisLab VisLab VisLab approved these changes

Assignees

@happy5214 happy5214

Labels
bids BIDS integration enhancement New feature or request help wanted Extra attention is needed tests Issues related to testcases
Projects
None yet
Milestone
3.13.5
Development

Successfully merging this pull request may close these issues.

Pass TSV line number through to BidsHedIssue object
2 participants
@happy5214 @VisLab