Enable benchmarks #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently blocked on #74 as we need connection acquisition and other metrics to calculate some benchmarks. |
danieljharvey
force-pushed
the
djh/NDAT-1031/enable-benchmarks
branch
from
0fcdc68 to
b0e452a
Compare
|
Needs #76 too |
danieljharvey
force-pushed
the
djh/NDAT-1031/enable-benchmarks
branch
from
8cf669e to
13ce520
Compare
danieljharvey
commented
Nov 16, 2023
i-am-tom
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add benchmarks like we have for
ndc-postgres.Look! https://didactic-carnival-j58qjg8.pages.github.io/dev/bench/
How
Copy and paste everything, make the minimal fixes.