Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing predicates tests #69

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

danieljharvey
Copy link
Collaborator

What

Add any new predicates tests from ndc-postgres.

How

Copy pasta. Removed ilike and any regex-related one as we're not supporting that.

@danieljharvey danieljharvey requested a review from plcplc November 14, 2023 10:39
@danieljharvey
Copy link
Collaborator Author

Merge #68 first pls.

@danieljharvey
Copy link
Collaborator Author

Looks like the array relationship test is failing.

We need to change ... INNER JOIN WHERE (predicate) ON (true) to ...INNER JOIN ON (predicate) so the scoping still works. Vaguely remember doing this before actually.

@soupi
Copy link
Contributor

soupi commented Nov 15, 2023

@danieljharvey that's weird. I'd expect the inner join to use ON in the postgres version as well.

@danieljharvey
Copy link
Collaborator Author

@danieljharvey that's weird. I'd expect the inner join to use ON in the postgres version as well.

It's INNER JOIN LATERAL in ndc-postgres, so I guess that's why the scoping is happy there?

@danieljharvey danieljharvey force-pushed the djh/NDAT-1025/fix-predicates branch from 91c018d to 76e02d4 Compare November 15, 2023 09:42
@danieljharvey danieljharvey added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit a7a8878 Nov 15, 2023
6 checks passed
@SamirTalwar SamirTalwar deleted the djh/NDAT-1025/fix-predicates branch November 20, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants