Basic table introspection #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
commented
Nov 9, 2023
| @@ -0,0 +1,245 @@ | |||
| //! Configuration and state for our connector. | |||
There was a problem hiding this comment.
moved from src/configuration.rs
danieljharvey
commented
Nov 9, 2023
| pub async fn configure( | ||
| configuration: &RawConfiguration, | ||
| ) -> Result<RawConfiguration, connector::UpdateConfigurationError> { | ||
| let mssql_pool = create_mssql_pool(configuration).await.unwrap(); |
There was a problem hiding this comment.
Changes start in here.
danieljharvey
commented
Nov 9, 2023
danieljharvey
force-pushed
the
djh/table-introspection
branch
from
da9f485 to
92e2421
Compare
danieljharvey
commented
Nov 9, 2023
| @@ -0,0 +1,210 @@ | |||
| //! Implement the `/schema` endpoint to return the connector's schema. | |||
There was a problem hiding this comment.
Copy pasta'd entirely from ndc-postgres
danieljharvey
force-pushed
the
djh/table-introspection
branch
from
bbf13d2 to
0705070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This implements the most basic table introspection. We use the SQL from HGE, and keep the
metadatatypes the same asndc-postgres.How