Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env vars present in model.json file #3

Merged
merged 16 commits into from
Oct 14, 2024
Merged

Update env vars present in model.json file #3

merged 16 commits into from
Oct 14, 2024

Conversation

pranshi06
Copy link
Contributor

No description provided.

pranshi06 and others added 15 commits October 2, 2024 20:22
@pranshi06
wip: update model.json file using env vars from connector-metadata.yaml
74e6d23
@pranshi06
remove commented code and add explanation comments
61ca1ec
@pranshi06
remove debug statements
556dadf
@pranshi06
update identifier
79199d6
@pranshi06
update identifier to {{*}}
e19124a
@pranshi06
fix env read in case it is required and a defualt is present
7fcda2d
@dventimihasura
Fixed the build dir for calcite
595ec27
@dventimihasura
Getting the context path from the docker container
10ec494
@dventimihasura
Getting the context path from the docker container
50cc00a
@dventimihasura
Merge branch 'main' into py/update-model-file
0c89dcd
@dventimihasura
Reverted vec![]
6e2cf5e
update the model file path and get the model context path from the do…
8d761ee 
…cker container
@dventimihasura
Updated with this line provided by Ken
c7c52f5 
COPY --from=java-build /calcite-rs-jni/jni/target/ /calcite-rs-jni/jni/target/
@dventimihasura
Merge branch 'main' into py/update-model-file
6ed2d9e
@dventimihasura
merging
5a92791
@gneeri gneeri requested a review from kenstott October 11, 2024 18:50
@gneeri gneeri marked this pull request as ready for review October 11, 2024 18:52
kenstott
kenstott approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@kenstott kenstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. It's a poor practice to commit commented code.

@gneeri gneeri merged commit 9f13e9c into main Oct 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenstott kenstott kenstott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranshi06 @kenstott @gneeri @dventimihasura