Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slient mode with cli usage #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

clementlecorre
Copy link

No description provided.

@hasura-bot
Copy link

Beep boop! 🤖

Hey @clementlecorre, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @clementlecorre. It works :)
However, I'd suggest adding cli.action in the ctx and make it aware of the silent flag so that we don't have to check it everywhere.

Once done, we'd use ctx.action.stop instead of cli.action.stop.

Does that make sense?

@clementlecorre clementlecorre force-pushed the feautre/support-silent-mode branch from 7ab3200 to e46b5c6 Compare June 28, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants