Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI times #1070

Closed
wants to merge 2 commits into from
Closed

Improve CI times #1070

wants to merge 2 commits into from

Conversation

meooow25
Copy link
Contributor

Let's see if this affects CI times...

@meooow25
Copy link
Contributor Author

meooow25 commented Nov 16, 2024 •
edited
Loading

For GHC 9.10,

master:
total: 11m 38s
build w/o tests: 4m 41s
build: 2m 56s

here:
total: 9m 27s
build w/o tests: 1m 25s
build: 4m 22s

Other steps seem unaffected.

Looks like a compilation of vector is gone, saving ~2m.

@meooow25
Copy link
Contributor Author

meooow25 commented Nov 16, 2024 •
edited
Loading

It seems that another time sink is building text, because of tasty -> optparse-applicative -> prettyprinter-ansi-terminal -> prettyprinter. prettyprinter has a flag for disabling the text dependency but it breaks prettyprinter-ansi-terminal: quchen/prettyprinter#250

Edit: I missed that optparse-applicative depends on text directly since 0.18, making the prettyprinter issue moot.

@meooow25 meooow25 changed the title Drop unnecessary deps from the testing copy Improve CI times Nov 16, 2024
@meooow25
Copy link
Contributor Author

nothunks gets removed in #1071.

@meooow25 meooow25 closed this Nov 21, 2024
@meooow25 meooow25 deleted the test-deps-drop branch November 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meooow25