This repository has been archived by the owner on Jun 9, 2019. It is now read-only.
Check for CRLF, and add .stdout/stderr to suffixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @hvr. I'd really like to see this merged. Since opening this pull request, new files with Windows line endings have entered the testsuite, as well as files with missing EOL. The longer we wait with this, the more cleanup work (and git history pollution) there will be. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5.
When you run 'make accept', the testsuite driver removes "\r" before writing any output: https://github.com/ghc/ghc/blob/176be87cb28f675d87ea8f5c07eaef7ca47ff8de/testsuite/driver/testlib.py#L1546
SPJ recently added a commit that introduced CRLF, in https://github.com/ghc/ghc/blob/bb7f23084e2a886f5b48442458d33b43c4628b3c/testsuite/tests/typecheck/should_fail/T11541.stderr.
Perhaps he ran something like
ghc -c T11541.hs 2> T11541.stderrinstead ofmake accept TEST=T11541. Unless I'm missing something, I think we're just going to have to ask him to not do that.