Added disambiguation that creation request can also update roles #17371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Jan 27, 2023
changelog/17371.txt
Outdated
Comment on lines
1
to
3
| ```release-note:improvement | ||
| website/docs: Added disambiguation for auth methods to clarify POST requests can both create and update roles. | ||
| ``` |
There was a problem hiding this comment.
We don't usually include a changelog entry for docs updates, so this could be removed (and then add the no-changelog label to skip the CI check).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current documentation can confuse users. The disambiguation is useful as Vault does not use a traditional distinction between create, update & partial update operations via the POST, PUT & PATCH http verbs.
Makes all auth engines consistent as many of them such as Kerberos, LDAP or AppRole already use this pattern for clarification.