Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current state of helm_template with test passing #1532

Open
wants to merge 10 commits into
base: helm-framework
Choose a base branch
from

Conversation

JaylonmcShan03
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 commented Nov 13, 2024

Description

Previously, helm_template failed in the entire test suite. After taking a look, a lot of the Read functions logic didn't address key points, or had logic in incorrect spots. This pr fixes those hiccups, and now we have 3/4 test passing, in the test suite now. The remaining failed test, I will debug and fix in a follow up pr!

The two test configs, needs the set attributes fixed! You might not see the test passing currently, due to me fixing the test config, in a previous pr!

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Acceptance test:

2024-11-13T07:20:29.805-0600 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccDataTemplate_kubeVersion
--- PASS: TestAccDataTemplate_kubeVersion (1.76s)
PASS
ok      [github.com/hashicorp/terraform-provider-helm/helm-framework/helm](http://github.com/hashicorp/terraform-provider-helm/helm-framework/helm)

2024-11-13T07:21:23.744-0600 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccDataTemplate_basic
--- PASS: TestAccDataTemplate_basic (0.44s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm-framework/helm        1.507s
jaylon.mcshan@jaylon terraform-provider-helm % 

2024-11-13T07:21:47.503-0600 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccDataTemplate_templates
--- PASS: TestAccDataTemplate_templates (0.43s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm-framework/helm        1.501s

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner November 13, 2024 13:37
@JaylonmcShan03 JaylonmcShan03 force-pushed the Current-state-of-helm-template branch from 4e0b853 to 4533828 Compare December 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants